Fix issue #363: add exact regression coverage for C# phantom string symbols - #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #363.
This PR adds exact regression coverage for the user-reported C# phantom-symbol fixture involving raw strings, interpolated raw strings, and multi-line verbatim strings.
What changed
SymbolExtractorTestsexact repro for issue C# raw string phantom symbols persist:"""...""",$"""...""", and@"..."content still captured as real symbols (#177 regression) #363.QueryCommandRunnerTestsend-to-endRunSymbolsregression for the same fixture.Why
The underlying masking behavior is already present on current
main, but issue #363's exact dogfood fixture was not pinned directly in the test suite. This PR prevents silent regression of that specific report.Validation
dotnet testdotnet ./src/CodeIndex/bin/Debug/net8.0/cdidx.dll index ...andsymbols --db ... --jsonorigin/main...HEADwith no blocking/actionable findings