Choose canonical C# partial declaration representatives - #5042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Partial declarations were stored as separate physical symbols, while grouping and representative selection reconstructed identity from incomplete signature, container, and path evidence. That could merge unrelated declarations, split valid families, or choose an unstable navigation target, especially around file-local/nested types, nullable custom types, hooks, and project boundaries.
User impact
Grouped C# queries now return a stable, explainable representative and bounded family members. Navigation defaults to that representative,
goto --allstill returns all physical locations, and impact traversal includes callers attached to either declaration site.Validation
dotnet build CodeIndex.sln -c Release --no-restore -p:UseSharedCompilation=false— passed with 0 warnings and 0 errorsdotnet format CodeIndex.sln --verify-no-changes --no-restore— passeddotnet run --project tools/CodeIndex.Changelog -- check— 109 fragments validgit diff --check— passedNo blocking/actionable issues found.Documentation and changelog
Updated
USER_GUIDE.md,TESTING_GUIDE.md, andCOMPATIBILITY.md. Added bilingualchangelog.d/unreleased/4914.changed.md.Fixes #4914