Skip to content

Add bounded suggestion history queries - #5073

Merged
Widthdom merged 4 commits into
mainfrom
fix-issue5061
Aug 10, 2026
Merged

Add bounded suggestion history queries#5073
Widthdom merged 4 commits into
mainfrom
fix-issue5061

Conversation

@Widthdom

@Widthdom Widthdom commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add redaction-safe NFKC full-text search across documented suggestion-history fields before pagination.
  • Add authoritative count, capped summary, compact four-field, and UTF-8 byte-bounded JSON projections with truthful omission and recovery metadata.
  • Keep sidecar reads bounded, preserve deterministic ordering, and fit whole rows with logarithmic prefix search.
  • Document the new surface in the English and Japanese guides and add the required bilingual changelog fragment.

Root cause

Suggestion history exposed structured filters and pagination, but had no local text search or low-output aggregate/bounded projection. Duplicate preflight therefore required listing or exporting large portions of the local store.

User impact

Users can search stored suggestion history and answer duplicate-triage questions without exporting full descriptions or contexts. Pagination and byte truncation now expose authoritative counts, omission reasons, and a deterministic next offset while preserving existing redaction.

Validation

  • Release solution build after rebasing onto the latest origin/main: 0 warnings, 0 errors.
  • Final focused Release regression suite after adversarial-review fixes, CI manifest correction, and the latest rebase: net8.0 441 passed; net9.0 400 passed, 41 production-runtime tests skipped as designed.
  • Full Release baseline: net8.0 11,237 passed / 7 skipped; net9.0 10,768 passed / 415 skipped.
  • All JSON golden snapshots pass, including the new suggestions-compact.json contract.
  • dotnet format CodeIndex.sln --verify-no-changes --no-restore passed.
  • The CI-failing CLI contract manifest test and all JSON snapshot tests pass on net8.0 and net9.0 (14/14 each).
  • dotnet run --project tools/CodeIndex.Changelog -- check validated all 10 fragments.
  • cdidx status --check reports the index matches the clean final workspace.
  • Two required adversarial Codex review rounds completed; every reported finding was addressed, including logarithmic byte fitting, omission accounting, zero-length page recovery, testing-guide coverage, surrogate-safe title truncation, and golden snapshot coverage.
  • A 5,000-record tight-byte-budget repro improved from about 9.37 seconds to 0.37 seconds while remaining valid bounded JSON.

Documentation and changelog

Follow-ups

None.

Fixes #5061

@Widthdom
Widthdom marked this pull request as ready for review August 10, 2026 18:25
@Widthdom
Widthdom merged commit 7d2bace into main Aug 10, 2026
12 checks passed
@Widthdom
Widthdom deleted the fix-issue5061 branch August 10, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add bounded full-text query and summary modes to suggestion history

1 participant