Remove obsolete private language capability constants - #5268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the ten obsolete private language capability constants and the partial file that contained only them. Capability matching and validation already delegate to
LanguageCapabilityCatalog; accepted values, CLI/MCP schemas, and shell completions retain their existing behavior.Fixes #5262
Verification of removal:
cdidx find <name> --all --json --limit 20 --include-generated --db .cdidx/codeindex.db. Every search returned only its declaration withscan_complete: true, authoritative rows, and no truncation.Validation:
dotnet format CodeIndex.sln --verify-no-changes --no-restorepassed.dotnet run --project tools/CodeIndex.Changelog -- checkpassed.dotnet test -p:UseSharedCompilation=falseis still running, so full-suite success is not yet confirmed. Test/format/review execution required normal permissions because the sandbox blocked local IPC initialization.origin/main..HEAD: No blocking/actionable issues found.index_matches_workspace: true; the workspace check reports both members healthy.PR status: no merge conflicts. Changelog validation and Actions CodeQL passed; the other CI lanes were still pending after three bounded checks.
Documentation: public documentation needs no update because this is behavior-neutral removal of unused private declarations. Added bilingual internal fragment
changelog.d/unreleased/5262.internal.md;CHANGELOG.mdis unchanged. No source-absence test was added.Follow-up issues: none identified.