Conversation
Already GPL'd by the ECDSA code, so this has no practical effect other than not stating an incorrect license
hwalker56
approved these changes
Apr 24, 2026
Member
hwalker56
left a comment
hwalker56
left a comment
There was a problem hiding this comment.
As mentioned, code was already under GPLv2 due to ecdsa.go. However, we need to seek permission from people who contributed before this was added (12th June 2025).
Member
|
@TCAtrevor, @kouacc, @nami1yt |
Contributor
I'm ok with this licensing change. I wouldn't mind it really. |
Member
Completely okay with it |
TCAtrevor
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Already GPL'd by the ECDSA code, so this has no practical effect other than not stating an incorrect license