XW-2076 | preparing Footer for rebranding #68
Conversation
|
Should we update reference page? |
limit size of logo
| display: flex; | ||
| justify-content: center; | ||
| margin: 0; | ||
| padding: 30px 0 25px; |
There was a problem hiding this comment.
Does it look how it should with the current logos?
|
Yes, we should update the reference page. We should also support the case where there's no |
components/_global-footer.scss
Outdated
|
|
||
| &__header-logo { | ||
| height: 45px; | ||
| width: 185px; |
There was a problem hiding this comment.
Why 185 x 45? SVG has width="184" height="44".
There was a problem hiding this comment.
They're perfectly rounded to full pixel. ;)
| <svg width="254" height="26" viewBox="0 0 254 26" xmlns="http://www.w3.org/2000/svg"> | ||
| <defs> | ||
| <linearGradient x1="0%" y1="100%" x2="63.848%" y2="32.54%" id="logo-fandom-powered-by-wikia-gradient"> | ||
| <linearGradient x1="0%" y1="100%" x2="63.848%" y2="32.54%" id="a"> |
There was a problem hiding this comment.
This is not a good change, I think we should manually revert / fix all those ids to be unique.
There was a problem hiding this comment.
That was probably caused by svgo run without config. I'll revert that.
There was a problem hiding this comment.
Fixed that. However, the new SVG logo-fandom-powered-by-wikia-two-lines.svg had just generic IDs like path-1. The SVGs merged from master also have generic IDs like a.
There was a problem hiding this comment.
BTW, was it a single comment or a review? It didn't disappear after the changes. 😞
|
In this PR we changes logo spacing for international version - see VRT. Was it intended? |
|
@hakubo could you answer @kvas-damian's comment #68 (comment)? |
|
@kvas-damian not intended. but this way we minimise the work needed to be done on Oct 4th. |
|
confirmed with Derek, it's fine to change these paddings |
|
Please update VRT! |
5 participants
Footer has to be ready to properly render these changes: Wikia/app#11396.
@Wikia/x-wing