Skip to content

Conversation

@lukaszkonieczny
Copy link
Contributor

Based on svg's clean up made in #68 we added some more changes:

  • change badges size to 18px - there were unnecessary empty space
  • moved badges into graphics folder - after talk with Ania Koronowicz (and she discussed it with Derek) avatar badges should not be treated as icons and should not be customizable, that's why we created new folder in assets
  • update avatar section on the reference page

@Wikia/west-wing @Wikia/x-wing

@idradm
Copy link
Contributor

idradm commented Sep 21, 2016

Have you thought about adding a ready for use with user avatars CSS classes?

e.g.: wds-staff-badge class added to any element would produce a staff badge on its left top corner.

@lukaszkonieczny
Copy link
Contributor Author

@Wikia/x-wing What do you think about @idradm idea?

@kvas-damian
Copy link
Contributor

@lukaszkonieczny If this the main use-case for those badges, then I agree with @idradm - we should create a component for that in DS.

@rogatty
Copy link

rogatty commented Sep 22, 2016

wds-staff-badge class added to any element would produce a staff badge on its left top corner.

If adding this class is enough to show a badge it means that we need to inline SVG in the CSS as a background. We wanted to avoid doing that because of the performance impact (CSS blocks page render, SVG doesn't) and the lack of possibility to customize those assets, e.g. modifying their fill color.

What @kvas-damian proposes is to create a DS component that has its markup described and which each client has to generate, together with the SVG.

@Warkot Warkot changed the base branch from XW-2076 to master September 22, 2016 11:50
@lukaszkonieczny lukaszkonieczny merged commit d16ff94 into master Sep 22, 2016
@lukaszkonieczny lukaszkonieczny deleted the WW-329 branch September 22, 2016 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants