-
Notifications
You must be signed in to change notification settings - Fork 16
WW-329: Move avatar badges from icons to graphics #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Have you thought about adding a ready for use with user avatars CSS classes? e.g.: |
|
@Wikia/x-wing What do you think about @idradm idea? |
|
@lukaszkonieczny If this the main use-case for those badges, then I agree with @idradm - we should create a component for that in DS. |
If adding this class is enough to show a badge it means that we need to inline SVG in the CSS as a background. We wanted to avoid doing that because of the performance impact (CSS blocks page render, SVG doesn't) and the lack of possibility to customize those assets, e.g. modifying their fill color. What @kvas-damian proposes is to create a DS component that has its markup described and which each client has to generate, together with the SVG. |
Based on svg's clean up made in #68 we added some more changes:
@Wikia/west-wing @Wikia/x-wing