Truncate page numbering on Review pages (T186497)#115
Truncate page numbering on Review pages (T186497)#115jsnshrmn merged 5 commits intoWikipediaLibrary:masterfrom uyscuti-wiki:page-fix
Conversation
|
Once you get to page 10, the format will be - Previous page, 1, 2, 3, ..., 9, 10 (focused), 11, Next page, Last page. Similarly for the pages further. When you get to the last page, there will be no next page number, next page button itself will be disabled and so will the Last page button. |
|
When on a page lower than 10, it's not obvious that there are more than 10 pages. Maybe there could be a ... and then the last few page numbers before 'Next page'? That should probably always be the case actually, so it's more like 1 2 3 ... 12 13 14 ... 26 27 28 (assuming there are 28 pages). That way the user always has context of the maximum number of pages. |
|
A user will now be able to skip 9-11 pages at a time. Including the last three pages is possible, but I'd go with only one (to reduce clutter). Being able to skip pages is more practical, don't you think? Given the fact that we always link to the last page. |
if the last page isn't displayed, which is most of the time, a '...' before 'Next page' is shown
|
should now display '...' at the end signifying there's more |
jsnshrmn
left a comment
jsnshrmn
left a comment
There was a problem hiding this comment.
Functionally, this looks pretty good to me. Legibility-wise, the indentation is problematic. Make sure that the opening and closing tags for your conditional and loop blocks have the same level of indentation. Please collapse some of the newlines for nested li and a elements. There's enough going on here now that it would be helpful if you dropped a brief comment just ahead of each conditional block describing the aims of that bit of logic.
comment on conditional blocks, fix indents, few cleanups
|
Looks great! |
|
Thank you! |
3 participants
Limited the number of pages displayed on the review page.