Implement new My Library UI#767
Implement new My Library UI#767jsnshrmn merged 27 commits intoWikipediaLibrary:masterfrom suecarmol:suecarmol/T285556-implement-new-my-library
Conversation
jsnshrmn
left a comment
There was a problem hiding this comment.
I'm giving this a pretty thorough lookover, so this review might be in progress for a bit. In the interest of more expedient feedback, I'll post comments as things come up.
The first thing I've noticed is that the language select filter has some odd behavior. On a fresh load/ hard reload (shift + F5) I find it almost impossible to select a language with a mouse click. Clicking left mouse also scrolls the list down and selects whichever language is beneath the cursor when the button is released. I'm able to (unreliably) select a language with the mouse once I've already fiddled with the control and there is some state.
|
Okay, I've manually tested emulating several devices (phone, tablet, desktop) and several languages (including hebrew, which is rtl) and it's functionally good IMO, other than the aforementioned issue with filtering languages. Moving on to a readthrough. |
I do not see this behavior in Chrome or Firefox for Mac. Do you have more details about how to reproduce this error? |
|
It's very consistent for me on firefox 90 for ubuntu on this view, but I'm not seeing it on firefox 90 for windows or android on staging. |
|
I will do some more testing to try to reproduce this in a clean Linux vm to verify that it's not something weird about my system. |
|
We verified that this was a firefox 90.0 bug that's resolved in the current release, 90.02. |
jsnshrmn
left a comment
There was a problem hiding this comment.
This looks great! I have one inline nitpick on localization strings, but other than that this is good to go IMO.
|
I also fixed the |
Description
Implement the missing pieces of My Library UI after completing #762.
Rationale
This is part of TWL redesign efforts.
Phabricator Ticket
T285556
How Has This Been Tested?
Tested manually and created tests for the filters
Screenshots of your changes (if appropriate):
Types of changes
What types of changes does your code introduce? Add an
xin all the boxes that apply: