Skip to content

Create one-off email to notify users about Terms of Use update#781

Merged
jsnshrmn merged 1 commit intoWikipediaLibrary:masterfrom
suecarmol:suecarmol/T286897-create-email-terms-update
Aug 10, 2021
Merged

Create one-off email to notify users about Terms of Use update#781
jsnshrmn merged 1 commit intoWikipediaLibrary:masterfrom
suecarmol:suecarmol/T286897-create-email-terms-update

Conversation

@suecarmol
Copy link
Copy Markdown
Contributor

Description

Created the templates, signal, and task to send a one-off email to notify users about the terms of use update.

Rationale

Our Terms of Use specify that we will update users when we make substantive changes to it. The new library user experience whereby there is just one criterion for accessing the library requires a substantive change, so we need to notify users.

Phabricator Ticket

T286897

How Has This Been Tested?

Screenshots of your changes (if appropriate):

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

@suecarmol suecarmol requested a review from jsnshrmn August 6, 2021 23:50
@Samwalton9
Copy link
Copy Markdown
Member

Will this email send in the user's chosen language (where a translation has been completed)? I notice it doesn't have a lang parameter, which some other emails do.

Copy link
Copy Markdown
Member

@jsnshrmn jsnshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 😎

@jsnshrmn jsnshrmn merged commit 12e03b3 into WikipediaLibrary:master Aug 10, 2021
@suecarmol
Copy link
Copy Markdown
Contributor Author

Will this email send in the user's chosen language (where a translation has been completed)? I notice it doesn't have a lang parameter, which some other emails do.

I didn't think about that. @jsnshrmn, will the email be sent in a user's preferred language without passing a lang parameter?

@jsnshrmn
Copy link
Copy Markdown
Member

Will this email send in the user's chosen language (where a translation has been completed)? I notice it doesn't have a lang parameter, which some other emails do.

You are absolutely correct that we need to add that in. We can do a followup pass to catch that, but for now, we at least have the strings merged for translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants