Skip to content

Add lang parameter to terms of use update email#785

Merged
jsnshrmn merged 1 commit intoWikipediaLibrary:masterfrom
suecarmol:suecarmol/add-lang-to-terms-of-use-email
Aug 11, 2021
Merged

Add lang parameter to terms of use update email#785
jsnshrmn merged 1 commit intoWikipediaLibrary:masterfrom
suecarmol:suecarmol/add-lang-to-terms-of-use-email

Conversation

@suecarmol
Copy link
Copy Markdown
Contributor

Description

Add lang parameter to terms of use update email.

Rationale

If you add the lang parameter, then the user will receive the email in their preferred language.

Phabricator Ticket

T286897

How Has This Been Tested?

Screenshots of your changes (if appropriate):

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

@suecarmol suecarmol requested a review from jsnshrmn August 10, 2021 22:54
Copy link
Copy Markdown
Member

@jsnshrmn jsnshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 In the interest of being extra cautious, I (locally) created a fake german translation string, ran the translation script, and then fired this email. I checked the output and verified that my fake string was in the output. All good. Thanks!

@jsnshrmn jsnshrmn merged commit f5eb6b5 into WikipediaLibrary:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants