Skip to content

Update sections of text in Terms of Use#787

Merged
jsnshrmn merged 3 commits intoWikipediaLibrary:eligibility-updatefrom
suecarmol:suecarmol/T285760-update-text-terms-of-use
Aug 11, 2021
Merged

Update sections of text in Terms of Use#787
jsnshrmn merged 3 commits intoWikipediaLibrary:eligibility-updatefrom
suecarmol:suecarmol/T285760-update-text-terms-of-use

Conversation

@suecarmol
Copy link
Contributor

Description

Updated several sections in the terms of use.

Rationale

n the Terms of Service and Privacy Policy page we need to make some changes to reflect a small change to the way library eligibility is handled (T285557). There are also a couple of areas we want to tidy up and clarify as part of the same change.

Phabricator Ticket

T285760

How Has This Been Tested?

Screenshots of your changes (if appropriate):

Screen Shot 2021-08-11 at 14 08 23

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

Copy link
Member

@jsnshrmn jsnshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than one string which has an inline comment. Thanks!

@suecarmol
Copy link
Contributor Author

I might've already asked this question elsewhere, but why do we keep each term paragraph in one line? Splitting each paragraph into more lines would make it more legible.

@suecarmol suecarmol requested a review from jsnshrmn August 11, 2021 22:06
@jsnshrmn
Copy link
Member

I might've already asked this question elsewhere, but why do we keep each term paragraph in one line? Splitting each paragraph into more lines would make it more legible.

I don't think there is a good reason. Now that we have verified this change, feel free to break them up on this pr. It's functionally identical and will make future changes easier to check.

@jsnshrmn
Copy link
Member

If you don't want to make that change here, this is otherwise ready to merge. Just let me know!

@suecarmol
Copy link
Contributor Author

I might've already asked this question elsewhere, but why do we keep each term paragraph in one line? Splitting each paragraph into more lines would make it more legible.

I don't think there is a good reason. Now that we have verified this change, feel free to break them up on this pr. It's functionally identical and will make future changes easier to check.

Will do! I'm making the change now! I'll let you know when I'm done!

@suecarmol
Copy link
Contributor Author

Done!

@jsnshrmn jsnshrmn merged commit 3a09114 into WikipediaLibrary:eligibility-update Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants