EDS Feature#826
Merged
Merged
Conversation
suecarmol
force-pushed
the
EDS-feature
branch
from
edcd538 to
63fca8c
Compare
suecarmol
force-pushed
the
EDS-feature
branch
from
63fca8c to
f2c8c78
Compare
jsnshrmn
force-pushed
the
EDS-feature
branch
from
f2c8c78 to
3a5dda9
Compare
suecarmol
commented
Sep 30, 2021
jsnshrmn
reviewed
Sep 30, 2021
Member
jsnshrmn
left a comment
jsnshrmn
left a comment
There was a problem hiding this comment.
I came up with a filtering solution that appears to work; see inline suggestions. Definitely needs more testing.
Solution courtesy of Jason (thanks!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
searchablefieldsearchablefieldRationale
This will enable users to search multiple eligible collections and know which collections are searchable.
Phabricator Ticket
T240128
T270115
T290245
How Has This Been Tested?
Added tests and manual testing
Screenshots of your changes (if appropriate):
Types of changes
What types of changes does your code introduce? Add an
xin all the boxes that apply: