Skip to content

Updated criterion on About page#945

Merged
suecarmol merged 2 commits intoWikipediaLibrary:masterfrom
Ankit-Gupta18:T300486
Feb 1, 2022
Merged

Updated criterion on About page#945
suecarmol merged 2 commits intoWikipediaLibrary:masterfrom
Ankit-Gupta18:T300486

Conversation

@Ankit-Gupta18
Copy link
Copy Markdown
Contributor

@Ankit-Gupta18 Ankit-Gupta18 commented Jan 31, 2022

Description

Describe your changes in detail following the [commit message guidelines]

  1. Removed this point(You do not already have access to the resources you’re applying for through another library or institution) from the bulleted list
  2. Added a new sentence under the bulleted list which says: "If you are applying for an available collection, please first check that you don't already have access through another library or institution. If you do, please consider using that access rather than taking up a seat for this resource in The Wikipedia Library."

Rationale

Phabricator Ticket

//: # https://phabricator.wikimedia.org/T300486

How Has This Been Tested?

Screenshots of your changes (if appropriate):

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Minor change (fix a typo, add a translation tag, add section to README, etc.)

Copy link
Copy Markdown
Contributor

@suecarmol suecarmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this. I need you to make one small change before we can merge this!

Comment thread TWLight/templates/about.html Outdated
@Ankit-Gupta18
Copy link
Copy Markdown
Contributor Author

@suecarmol Addressed your reviews. Please review it and tell if its fine now.

Copy link
Copy Markdown
Contributor

@suecarmol suecarmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this!

@suecarmol suecarmol merged commit bc95dcd into WikipediaLibrary:master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants