Updated the renewal notification email#946
Merged
Merged
Conversation
suecarmol
requested changes
Jan 31, 2022
Contributor
suecarmol
left a comment
suecarmol
left a comment
There was a problem hiding this comment.
Thanks for your work on this. There is one small thing you need to make before I can merge this.
Contributor
Author
|
@suecarmol Addressed the changes. Please review it. |
Contributor
|
@Ankit-Gupta18 I can still see the changes for the other PR here. Please remove them or rebase this PR |
Contributor
Author
|
@suecarmol Please check it now. |
Addressed reviews
suecarmol
approved these changes
Feb 3, 2022
Contributor
suecarmol
left a comment
suecarmol
left a comment
There was a problem hiding this comment.
Thank you for your work on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changed instead of "by clicking the Renew button", this email by "by clicking the 'Renew' or 'Extend' button".
Rationale
[//: # (Why is this change required? What problem does it solve?)](https://phabricator.wikimedia.org/T300492)
Phabricator Ticket
How Has This Been Tested?
Screenshots of your changes (if appropriate):
Types of changes
What types of changes does your code introduce? Add an
xin all the boxes that apply: