Skip to content

chore: willboosterify this repo#2

Merged
exKAZUu merged 2 commits into
mainfrom
wbfy
Jul 22, 2026
Merged

chore: willboosterify this repo#2
exKAZUu merged 2 commits into
mainfrom
wbfy

Conversation

@WillBooster-bot

@WillBooster-bot WillBooster-bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Applies the latest wbfy (wb 16) to this repository.

Notable changes

  • Migrated to Bun's isolated linker with a global store, moved tool versions to mise.toml, renamed renovate.jsonrenovate.jsonc, and refreshed shared config/doc files.
  • Bumped tooling (wb 16, oxfmt 0.60, oxlint 1.75) and pinned the typescript peer dependency.

Fixes for isolated-linker type checking

The isolated-linker migration exposed two type-checking breakages, now fixed:

  1. Fixture tsconfig shim pathsnext/* shims are now resolved from the fixture-local node_modules, where the isolated linker places vinext (previously hoisted to the repo root).
  2. Root project pulling in the framework fixture — the root tsconfig.json now excludes e2e/fixture/app, so the fixture's app sources are type-checked only by their own tsconfig (which shims next/* via paths), not by the root project. This was fixed generally in wbfy itself: fix(wbfy): exclude framework workspace app dirs from the root tsconfig shared#1062.

bun verify passes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project configuration, guidelines, and dependencies, including transitioning from .tool-versions to mise.toml, switching Bun's linker to isolated in bunfig.toml, and adding a comprehensive E2E test fixture. Feedback on the changes suggests restoring the exclusion of e2e/fixture from the root tsconfig.json to prevent type-checking errors and eliminate redundancy, as well as reverting the empty typescript peer dependency range in package.json back to "*" to ensure compatibility.

Comment thread tsconfig.json Outdated
Comment on lines +17 to +30
"exclude": ["e2e/fixture/test/fixtures", "test/fixtures"],
"extends": "@tsconfig/bun/tsconfig.json",
"include": ["*.config.ts", "e2e/**/*", "scripts/**/*", "src/**/*", "test/**/*", "types/**/*"]
"include": [
"*.config.ts",
"e2e/**/*",
"e2e/fixture/*.config.ts",
"e2e/fixture/scripts/**/*",
"e2e/fixture/src/**/*",
"e2e/fixture/test/**/*",
"scripts/**/*",
"src/**/*",
"test/**/*",
"types/**/*"
]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Including e2e/fixture files in the root tsconfig.json compilation will cause type-checking errors (e.g., during bun wb typecheck) because the root configuration lacks the specific path mappings (like next/link shims) and dependencies (like vinext) defined in the fixture's own tsconfig.json and package.json.

Additionally, explicitly listing subdirectories of e2e/fixture in include is redundant since e2e/**/* is already included, violating the repository style guide rule to eliminate redundancy.

We should restore the exclusion of e2e/fixture from the root compilation and let it be type-checked independently via its own configuration.

  "exclude": ["e2e/fixture", "test/fixtures"],
  "extends": "@tsconfig/bun/tsconfig.json",
  "include": [
    "*.config.ts",
    "e2e/**/*",
    "scripts/**/*",
    "src/**/*",
    "test/**/*",
    "types/**/*"
  ]
References
  1. Simplify code as much as possible to eliminate redundancy. Including specific subdirectories of e2e/fixture when e2e/**/* is already included is redundant. (link)

Comment thread package.json Outdated
"peerDependencies": {
"react": ">=18",
"typescript": "*"
"typescript": ""

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using an empty string "" as a version range for typescript in peerDependencies is highly non-standard and can cause warnings or resolution failures in strict package managers. It should be restored to "*" to indicate compatibility with any version.

Suggested change
"typescript": ""
"typescript": "*"

Update to the latest wbfy (wb 16) and fix two issues the isolated-linker
migration exposed:

- Point the fixture tsconfig's next/* shim paths at the fixture-local
  node_modules, where the isolated linker now places vinext (previously
  hoisted to the repo root).
- The root tsconfig now excludes e2e/fixture/app so the framework fixture's
  app sources are type-checked only by their own tsconfig (which shims
  next/* via paths), not by the root project (fixed in wbfy itself).

Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
@exKAZUu
exKAZUu merged commit 6f65f1c into main Jul 22, 2026
10 checks passed
@exKAZUu
exKAZUu deleted the wbfy branch July 22, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants