Skip to content

Fix Wine locale picker values and labels#264

Draft
ribbit384 wants to merge 4 commits intoWinNative-Emu:mainfrom
ribbit384:fix/app-locale-recreation-crash
Draft

Fix Wine locale picker values and labels#264
ribbit384 wants to merge 4 commits intoWinNative-Emu:mainfrom
ribbit384:fix/app-locale-recreation-crash

Conversation

@ribbit384
Copy link
Copy Markdown
Collaborator

@ribbit384 ribbit384 commented Apr 23, 2026

  • moves the Wine locale picker source out of arrays.xml and into Kotlin via WineLocaleUtils
  • replaces raw locale codes in the picker with explicit display labels while still saving normalized LC_ALL values
  • normalizes LC_ALL when loading, saving, and launching containers/shortcuts so values like de_DE become de_DE.UTF-8
  • updates both container settings and shortcut settings to share the same locale option source
  • removes the old some_lc_all XML array
  • intended impact: avoid crashes or bad runtime behavior from malformed Wine locale values and make the picker clearer
  • validation: code review only; local Gradle/build checks were not run because java / JAVA_HOME is not configured on this machine

@ribbit384 ribbit384 changed the title Fix app locale recreation crash when switching languages Fix Wine locale picker values and labels Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant