Remove MovementCache

[kalibrieren]

No description provided.

[windcolor-dev]

I feel like the movement cache is still a useful optimization. Did you notice anything particular that broke because of it?

[kalibrieren]

I feel like the movement cache is still a useful optimization. Did you notice anything particular that broke because of it?

These patches I'm removing are doing too much for too little/nothing, imo. So why clutter the MC server code more with classes like these?
Tested it, and the win in performance is negligible anyway - no real player will be able to tell.

[windcolor-dev]

I agree in that it probably doesn't have as much impact as say, the multi-threaded entity tracker.

But I feel that it's best to keep these "micro" optimizations. (I believe this patch was more geared towards memory allocations rather than TPS)

If it broke something or ended up making performance worse/increasing memory allocation, it would make sense to revert it. But otherwise, I don't see any reason to

[kalibrieren]

I agree in that it probably doesn't have as much impact as say, the multi-threaded entity tracker.

But I feel that it's best to keep these "micro" optimizations. (I believe this patch was more geared towards memory allocations rather than TPS)

If it broke something or ended up making performance worse/increasing memory allocation, it would make sense to revert it. But otherwise, I don't see any reason to

I don't think this will optimize memory much. If anything, it'll use more memory because we are caching and re-checking so often.

[windcolor-dev]

You're right, I tested it and it never really activates. I believe this patch from NachoSpigot makes the MovementCache redundant

			// [Nacho-0019] :: We must move a meaningful amount of distance to tick
			// collisions
			if (d0 * d0 + d1 * d1 + d2 * d2 < 0.0001D) {
				return;
			}