Cluster-tool: Drop base_per_transaction_net_usage from generated genesis#28
Conversation
wire-sysio removes the parameter from chain_config (it no longer participates in NET billing), so freshly generated genesis files must not carry it. Aligns the production-bootstrap doc table with the launcher defaults.
| max_block_net_usage: 1_048_576, | ||
| target_block_net_usage_pct: 10_000, | ||
| max_transaction_net_usage: 524_288, | ||
| base_per_transaction_net_usage: 12, |
There was a problem hiding this comment.
[P2] Please add a regression assertion for the removed field
This changes the generated genesis schema, but no test verifies that base_per_transaction_net_usage is absent. The existing genesis-renderer tests still pass if this deletion is reverted. Please add an assertion in packages/cluster-tool/tests/config/NodeConfig.test.ts against the parsed initial_configuration, as required by the repository test policy.
There was a problem hiding this comment.
Added in 4747809: NodeConfig.test.ts now parses the rendered genesis and asserts initial_configuration has no base_per_transaction_net_usage, anchored by a neighbor-field check so the assertion reads the right object. Reverting the renderer deletion fails the suite.
…_usage Review follow-up: lock the schema change in with a regression assertion on the parsed initial_configuration so reverting the renderer deletion fails the suite.
huangminghuang
left a comment
huangminghuang
left a comment
There was a problem hiding this comment.
Re-reviewed at 4747809. The regression test addresses the prior finding; local build and all 530 cluster-tool tests pass.
2 participants
Summary
wire-sysio removes
base_per_transaction_net_usagefromchain_config(Wire-Network/wire-sysio#519), so freshly generated genesis files must not carry it. Drops the field fromClusterConfigGenesisRendererand aligns the production-bootstrap doc table with the launcher defaults.Old genesis files that still carry the field parse fine (unknown keys are ignored) and produce the same chain id as without it; dropping it keeps generated files canonical.