fix(cli): narrow auto_setup gate — broad gate caused hours-long CI hang - #274
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
… auto-scan (CI hang)
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Mengapa
CI HEAD 3d8e0ee (dan #270-era) STUCK 123+ menit di step "Scan codebase" (Quality Gate) DAN "Run test suite" (CI) — bukan infinite loop, tapi mass-scanning.
Root cause = regresi dari PR #270 saya. Saat memperbaiki regresi
_auto_setup#244, saya bikin gate terlalu luas:Efek: SETIAP command (termasuk semua hidden leaf: check/analyze/entrypoints/list/query/...) yang dipanggil di workspace tanpa registry kini auto-scan dulu. Ratusan command-test × scan (di CI ~300s per scan repo-size) → suite meledak dari 164s (run baik 763ed95, sebelum #270) jadi berjam-jam.
Bukti
Perbaikan
Kembalikan ke allowlist eksplisit sempit: 11 umbrella +
list/query/symbols(hidden command yang memang baca registry & dibutuhkanTestAutoSetupFallbackCap). BUKAN "semua kecuali 3". Command seperti check/analyze/entrypoints tidak lagi auto-scan.Pelajaran
_REGISTRY_COMMANDSmenggigit 2× (#244 over-reduce, #270 over-broaden). Allowlist sempit eksplisit — jangan "exclude a few".