Skip to content

fix(cli): narrow auto_setup gate — broad gate caused hours-long CI hang - #274

Merged
Wolfvin merged 1 commit into
mainfrom
fix/auto-setup-broad-gate-mass-scan
Jul 14, 2026
Merged

fix(cli): narrow auto_setup gate — broad gate caused hours-long CI hang#274
Wolfvin merged 1 commit into
mainfrom
fix/auto-setup-broad-gate-mass-scan

Conversation

@Wolfvin

@Wolfvin Wolfvin commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Mengapa

CI HEAD 3d8e0ee (dan #270-era) STUCK 123+ menit di step "Scan codebase" (Quality Gate) DAN "Run test suite" (CI) — bukan infinite loop, tapi mass-scanning.

Root cause = regresi dari PR #270 saya. Saat memperbaiki regresi _auto_setup #244, saya bikin gate terlalu luas:

_NON_REGISTRY_COMMANDS = {"scan", "plugin", "lsp"}
if args.command not in _NON_REGISTRY_COMMANDS and not _registry_exists(workspace): _auto_setup(...)

Efek: SETIAP command (termasuk semua hidden leaf: check/analyze/entrypoints/list/query/...) yang dipanggil di workspace tanpa registry kini auto-scan dulu. Ratusan command-test × scan (di CI ~300s per scan repo-size) → suite meledak dari 164s (run baik 763ed95, sebelum #270) jadi berjam-jam.

Bukti

Perbaikan

Kembalikan ke allowlist eksplisit sempit: 11 umbrella + list/query/symbols (hidden command yang memang baca registry & dibutuhkan TestAutoSetupFallbackCap). BUKAN "semua kecuali 3". Command seperti check/analyze/entrypoints tidak lagi auto-scan.

Pelajaran

_REGISTRY_COMMANDS menggigit 2× (#244 over-reduce, #270 over-broaden). Allowlist sempit eksplisit — jangan "exclude a few".

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@Wolfvin
Wolfvin merged commit 39ccc62 into main Jul 14, 2026
0 of 6 checks passed
@Wolfvin
Wolfvin deleted the fix/auto-setup-broad-gate-mass-scan branch July 14, 2026 02:40
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant