Skip to content

Update composer dependencies #2736

Merged
dtdesign merged 4 commits into
nextfrom
composer-deps
Nov 7, 2018
Merged

Update composer dependencies #2736
dtdesign merged 4 commits into
nextfrom
composer-deps

Conversation

@TimWolla
Copy link
Copy Markdown
Member

Care should be taken to review the changes to htmlpurifier (message processing) and emogrifier (emails).

@TimWolla TimWolla added this to the 3.2 milestone Aug 12, 2018
@TimWolla TimWolla requested a review from dtdesign August 12, 2018 13:08
@jens1o
Copy link
Copy Markdown
Contributor

jens1o commented Aug 18, 2018

What's up with the SCSS Compiler? It reached v0.7.6, compared to the used v0.3.0 version.

@TimWolla
Copy link
Copy Markdown
Member Author

An upgrade was attempted in 2016 and then reverted: https://github.com/WoltLab/WCF/commits/master/wcfsetup/install/files/lib/system/style/scssphp/scss.inc.php

The performance of newer version was horrible, if I remember correctly.

@jens1o
Copy link
Copy Markdown
Contributor

jens1o commented Aug 18, 2018

I expect 3.2 to be published in early 2019, so what about giving it another try?

@Morik
Copy link
Copy Markdown
Contributor

Morik commented Aug 27, 2018

The massive performance loss is due to the utf8 support in scss indentifers added in v0.6.2.
See https://github.com/leafo/scssphp/commit/dbca8da31c3cfd5cfd9c7b2c5a0a74310fc248ae
You can disable it by calling $this->compiler->setEncoding('iso8859-1'); after initialization.
This gives you about the same performance as v0.3.0 currently used.

@dtdesign dtdesign self-assigned this Oct 29, 2018
@dtdesign dtdesign merged commit 75033e2 into next Nov 7, 2018
@Morik
Copy link
Copy Markdown
Contributor

Morik commented Nov 7, 2018

And what about scssphp?
Do you plan to stick on that outdated version?
The current version is 0.7.7...

@TimWolla TimWolla deleted the composer-deps branch November 15, 2018 19:24
@TimWolla TimWolla mentioned this pull request Nov 29, 2018
TimWolla added a commit that referenced this pull request Nov 29, 2018
TimWolla added a commit that referenced this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants