Skip to content

Add EmailMultifactorMethod#3729

Merged
TimWolla merged 5 commits intomfa-metafrom
mfa-email
Nov 18, 2020
Merged

Add EmailMultifactorMethod#3729
TimWolla merged 5 commits intomfa-metafrom
mfa-email

Conversation

@TimWolla
Copy link
Copy Markdown
Member

  • Add Setup::getUser() method
  • Add EmailMultifactorMethod

Comment thread wcfsetup/install/lang/de.xml Outdated
<item name="wcf.user.security.multifactor.email.code"><![CDATA[Einmalcode]]></item>
<item name="wcf.user.security.multifactor.email.code.description"><![CDATA[Der Einmalcode wurde um <strong>{$lastCode|date:'H:i:s'}</strong> an {if LANGUAGE_USE_INFORMAL_VARIANT}deine{else}Ihre{/if} E-Mail-Adresse bei <strong>{$emailDomain}</strong> gesendet.]]></item>
<item name="wcf.user.security.multifactor.email.subject"><![CDATA[{if LANGUAGE_USE_INFORMAL_VARIANT}Dein{else}Ihr{/if} Einmalcode for {@PAGE_TITLE|language}]]></item>
<item name="wcf.user.security.multifactor.email.body.html"><![CDATA[{if LANGUAGE_USE_INFORMAL_VARIANT}Dein{else}Ihr{/if} Einmalcode lautet: <pre>{$code}</pre>]]></item>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect a short text here why this email came. I would also highlight the one-time code with some CSS (bigger and possibly in a box in the middle), so that it can be found visually quickly.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrasing is somewhat intentional here for several reasons:

  1. The email address most likely is already confirmed to belong to the account.
  2. Thus the email does not go to unrelated persons.
  3. The user expects the email to arrive, because they are sitting right in front of a form that requires it.

That's why I opted to keep the email free from any fluff and get straight to the point. Specifically I avoided including any links whatsoever to reduce chances for phishing based off this type of verification email. As a best practice also avoided including personal information in case the email gets misrouted for some reason.

But I'm happy to make some adjustments to the phrasing / layout if you feel that the UX improvement weights enough.

Comment thread wcfsetup/install/lang/de.xml Outdated
@TimWolla TimWolla merged commit ece1d82 into mfa-meta Nov 18, 2020
@TimWolla TimWolla deleted the mfa-email branch November 18, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants