Update CodeMirror to version 5.61.1 and use it with requireJS#4277
Merged
3 commits merged intomasterfrom Jun 10, 2021
Merged
Conversation
added 3 commits
June 10, 2021 11:06
With this change, the original folder structure from CodeMirror is preserved, i.e. `codemirror.js` and `codemirror.css` being in a `lib` folder. To preserve backward-compatibility if codemirror is used directly, these files are also kept in the `codemirror` folder directly.
ghost
requested a review
from 
TimWolla
approved these changes
Jun 10, 2021
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, the original folder structure from CodeMirror is preserved, i.e.
codemirror.jsandcodemirror.cssbeing in alibfolder.To preserve backward-compatibility if codemirror is used directly, these files are also kept in the
codemirrorfolder directly.For reviewing, the second and third commit are relevant.