Modernize color picker and add ColorFormField#4353
Merged
10 commits merged intomasterfrom Jul 2, 2021
Merged
Conversation
ghost
added
the
ghost
requested a review
from
added 3 commits
July 1, 2021 10:09
Instead of having to implement a color picker ourselves, we delegate the task to the browser by using a `input[type=color]` element. Because this color input does not support transparency, there is an additional `input[type=range]` element for transparency.
TimWolla
reviewed
Jul 1, 2021
TimWolla
approved these changes
Jul 2, 2021
ghost
pushed a commit
to WoltLab/docs.woltlab.com
that referenced
this pull request
Jul 2, 2021
ghost
pushed a commit
to WoltLab/docs.woltlab.com
that referenced
this pull request
Jul 2, 2021
ghost
pushed a commit
to WoltLab/docs.woltlab.com
that referenced
this pull request
Jul 2, 2021
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best reviewed commit by commit.