Skip to content

Deprecate HTTP_SEND_X_FRAME_OPTIONS#4477

Merged
TimWolla merged 2 commits intomasterfrom
xfo-deprecated
Aug 27, 2021
Merged

Deprecate HTTP_SEND_X_FRAME_OPTIONS#4477
TimWolla merged 2 commits intomasterfrom
xfo-deprecated

Conversation

@TimWolla
Copy link
Copy Markdown
Member

Shall I also add a warning message on IndexPage? Just adjusting the field
description might not be sufficiently visible and removal of this option might
bring signifant breakage unless anticipated.


Resolves #4474

@TimWolla TimWolla requested a review from dtdesign August 25, 2021 10:22
@dtdesign
Copy link
Copy Markdown
Member

Shall I also add a warning message on IndexPage?

Yes. I would like to see deprecated options that are subject to removal in the next version to show a warning on the index page. This should give operators enough time to plan ahead and adjust their setup.

@TimWolla TimWolla marked this pull request as draft August 25, 2021 13:21
@TimWolla TimWolla requested a review from dtdesign August 27, 2021 12:57
@TimWolla TimWolla marked this pull request as ready for review August 27, 2021 12:57
@TimWolla TimWolla merged commit 175b3ce into master Aug 27, 2021
@TimWolla TimWolla deleted the xfo-deprecated branch August 27, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate HTTP_SEND_X_FRAME_OPTIONS

2 participants