Merged
Conversation
The `finalizeLog()` method was initially added to support com.woltlab.wcf.elasticSearch, as it logged the full - possibly huge - Elasticsearch response, allowing it to log the response into a separate log file. This came with severe usability issues, as this log file is not readily available from the ACP. The Elasticsearch package was completely cleaned up, relying on the regular Guzzle exceptions, and errors during JSON decoding no longer include the full JSON. Letting the Exception know that they've been logged is a layering violation that will not play along nicely with #4342. The current method signature also is pretty much limited to logging into files only. Deprecate the interface, now that the only known user is gone.
dtdesign
approved these changes
Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
finalizeLog()method was initially added to supportcom.woltlab.wcf.elasticSearch, as it logged the full - possibly huge -
Elasticsearch response, allowing it to log the response into a separate log
file.
This came with severe usability issues, as this log file is not readily
available from the ACP.
The Elasticsearch package was completely cleaned up, relying on the regular
Guzzle exceptions, and errors during JSON decoding no longer include the full
JSON.
Letting the Exception know that they've been logged is a layering violation
that will not play along nicely with #4342. The current method signature also
is pretty much limited to logging into files only.
Deprecate the interface, now that the only known user is gone.