Clean up route processing in RequestHandler#4822
Merged
Conversation
This value is currently unused, incorrectly documented (`page` was a valid value since the addition of CMS pages), of questionable value and will break with the addition of PSR-15 controllers.
…RequestHandler::buildRequest() The variable is only referenced in the `else`, move it there to make the data flow clearer.
The `redirect()` method is only called in a single location where `$controller` will also be set to a string.
…Controller() By returning the updated data the data flow becomes clearer.
The value is unused and badly named, because it refers to the controller name and not the name of some page.
These array fields are never accessed after being unset.
… array It is only interested in the className field of the given array and taking a className directly makes the API clearer.
Since the recent changes only the `className` member of this array was access. Simplify this to a simple `$className` variable.
It now has an explicit “then” (ACP) and “else” (Frontend) part.
dtdesign
approved these changes
May 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.