Move ban checking from WCF boot to middleware#4935
Merged
Conversation
The previous location in WCF made sense back when `initBlacklist()` also checked the IP address, User-Agent, or hostname blocklist to prevent processing the request as much as possible. As all these checks are gone now, the only thing that remains is the inexpensive ban check. Move it into a middleware, it does not really belong into WCF which should just be responsible for booting the framework independently of the request in question.
BurntimeX
reviewed
Aug 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous location in WCF made sense back when
initBlacklist()alsochecked the IP address, User-Agent, or hostname blocklist to prevent processing
the request as much as possible. As all these checks are gone now, the only
thing that remains is the inexpensive ban check.
Move it into a middleware, it does not really belong into WCF which should just
be responsible for booting the framework independently of the request in
question.