Clean up and organize the package system#4947
Merged
Conversation
TimWolla
force-pushed
the
package-cleanup
branch
3 times, most recently
from
49c846f to
8dcc882
Compare
TimWolla
force-pushed
the
package-cleanup
branch
10 times, most recently
from
ce84537 to
63cf4da
Compare
TimWolla
force-pushed
the
package-cleanup
branch
2 times, most recently
from
9749f7c to
0bc43d0
Compare
…allPackageAction Inheriting from a barely related class is intransparent. This is evident by the need for `PhpUndefinedMethodInspection` in `stepUninstall()`.
AbstractDialogAction is effectively trivial, but its implicit logic makes the derived actions much harder to understand.
This is not used during WCFSetup, so the caveat does not apply.
…cher::completeSetup()
…or the empty node
This was introduced with the merge in the previous commit.
…ation This is expected to be a noop, because an uninstallation won't create any new fields.
This greatly reduces the size of the `if(!PACKAGE_ID)`.
…tion These were added to ClearCache command in the previous commit.
…stall event This is a more logical position, with only clean-up happening after the event.
…llationDispatcher::install()
It's as if `match()` was developed for this exact use case. `match()` will automatically throw if no arm matches, allowing for the removal of that questionable `exit` there.
… in IndexPage This method is only called there, so we can easily inline it to keep PackageInstallationDispatcher clean.
…allForm This method is only called there, so we can easily inline it to keep PackageInstallationDispatcher clean. This is especially useful, because the method directly calls redirect + exit which has no business of existing outside of a controller.
TimWolla
force-pushed
the
package-cleanup
branch
from
0bc43d0 to
8b367ed
Compare
dtdesign
approved these changes
Sep 14, 2022
Member
dtdesign
left a comment
dtdesign
left a comment
There was a problem hiding this comment.
I did not spot any obvious issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is likely best reviewed using a combination of "look at each commit to understand the evaluation" and "look at the 'Files Changes' tab to get the full picture".