Further clean up package archive handling logic#5126
Merged
Conversation
…ckage() The `foreach()` loops handle empty arrays just fine.
…nDispatcher::installPackage() The key will always exist in the `$nodeData`.
TimWolla
force-pushed
the
package-cleanup
branch
from
f2fc321 to
a811b46
Compare
…Archive This removes the only user of `PackageArchive::isValidUpdate()` which will be removed in a follow-up commit.
The method relies on the stateful `PackageArchive::$package` property and `PackageArchive::filterUpdateInstructions()` which is super intransparent. The last remaining user was removed in the previous commit. see #5094
dtdesign
approved these changes
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review recommended with Whitespace ignored.