Skip to content

Remove deprecated WCF.User.Registration.Validation.Password #5244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimWolla merged 1 commit into from
Jan 27, 2023
Merged

Remove deprecated WCF.User.Registration.Validation.Password #5244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions wcfsetup/install/files/js/WCF.User.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,43 +846,6 @@ WCF.User.Registration.Validation.EmailAddress = WCF.User.Registration.Validation
}
});

/**
* Password validation for registration.
*
* @see WCF.User.Registration.Validation
* @deprecated 5.3
*/
WCF.User.Registration.Validation.Password = WCF.User.Registration.Validation.extend({
/**
* @see WCF.User.Registration.Validation._actionName
*/
_actionName: 'validatePassword',

/**
* @see WCF.User.Registration.Validation._className
*/
_className: 'wcf\\data\\user\\UserRegistrationAction',

/**
* @see WCF.User.Registration.Validation._getParameters()
*/
_getParameters: function() {
return {
password: this._element.val()
};
},

/**
* @see WCF.User.Registration.Validation._setErrorMessages()
*/
_setErrorMessages: function() {
this._errorMessages = {
ajaxError: 'wcf.user.password.error.',
notEqual: WCF.Language.get('wcf.user.confirmPassword.error.notEqual')
};
}
});

/**
* Toggles input fields for lost password form.
*/
Expand Down
22 changes: 1 addition & 21 deletions wcfsetup/install/files/lib/data/user/UserRegistrationAction.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class UserRegistrationAction extends UserAction
/**
* @inheritDoc
*/
protected $allowGuestAccess = ['validateEmailAddress', 'validatePassword', 'validateUsername'];
protected $allowGuestAccess = ['validateEmailAddress', 'validateUsername'];

/**
* Validates the validate username function.
Expand All @@ -34,16 +34,6 @@ public function validateValidateEmailAddress()
$this->readString('email');
}

/**
* Validates the validate password function.
*
* @deprecated 5.3
*/
public function validateValidatePassword()
{
$this->readString('password');
}

/**
* Validates the given username.
*
Expand Down Expand Up @@ -95,14 +85,4 @@ public function validateEmailAddress()
'isValid' => true,
];
}

/**
* @deprecated 5.3 - Always returns isValid = true.
*/
public function validatePassword()
{
return [
'isValid' => true,
];
}
}