Stop using HTTPRequest for package update server requests#5973
Merged
Conversation
dtdesign
approved these changes
Aug 12, 2024
TimWolla
reviewed
Aug 14, 2024
Comment on lines
+236
to
+237
| if (!empty($response->getHeaders()['etag'])) { | ||
| $metaData['list']['etag'] = \reset($response->getHeaders()['etag']); |
Member
There was a problem hiding this comment.
Careful here (and in the other places where getHeaders() is used): The casing depends on the casing returned by the server [1], which is not necessarily lowercased [2].
The correct solution is $response->getHeaderLine('etag') (returns string, duplicate headers are comma-separated) or $response->getHeader('etag') (returns array) and possibly $response->hasHeader('etag').
[1]
[2] HTTP/2 guarantees lowercase and recent HAProxy versions emit lowercase by default even with HTTP/1.1, but other web servers will tend to use an uppercase character after every hyphen or so.
BurntimeX
added a commit
that referenced
this pull request
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.