E2E[Content Classification]: Prefer user-facing attributes #859
Conversation
Added unique IDs for classification hints and suggestions in the SuggestionPanel component to improve accessibility. Updated ARIA attributes to ensure proper screen reader support for the suggestion list and hint messages.
Replaced locator queries with Playwright's user-facing attributes for improved accessibility in the Content Classification experiment tests.
a998efc to
6a31fef
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #859 +/- ##
==========================================
Coverage 77.04% 77.04%
Complexity 2231 2231
==========================================
Files 103 103
Lines 9214 9214
==========================================
Hits 7099 7099
Misses 2115 2115
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @hasanmehmood. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@hasanmehmood if you can provide your WPORG username and link it to your GitHub profile, then I can ensure you're properly crediting in the WP AI release and receive the AI Contributor badge; thanks! |
What, Why, and How?
Closes #778
Playwright recommends using user-facing locators (example,
getByRole) instead of CSS classes or DOM-structure selectors wherever possible. This is because CSS classes and markup structure are implementation details that can change during design or refactoring without changing the actual user experience, which can make tests fail even though the feature still works (Docs).This PR updates the Content Classification E2E spec to follow the Playwright best practices by replacing hard-coded
page.locator(...)calls with role-based locators. This should make the test less brittle because it now targets the UI the way a user, or assistive technology, understands it rather than depending on implementation details.Use of AI Tools
AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5.6 Sol
Used for: Code review
Testing Instructions
Changelog Entry