Follow-up to #76: block-inspector precedence test, ROADMAP truth-up - #78
Merged
Conversation
Adds the regression test the #76 review flagged as missing: content lifecycle block [41] exercises loadBlockInspectorPref's precedence through the real content script — a _global default alone enables, an explicit per-origin false beats a _global true, per-origin true enables on its own, and nothing set leaves the inspector off. Verified the suite catches the guard regression it targets (replacing the typeof guard with a truthy check fails the new block). Corrects ROADMAP store states not visible outside the maintainer dashboards: v0.11.x reads as approved-pending-publication rather than shipped (the unlisted CWS submission is approved but not published); the Safari row and checklist reflect the App Store Connect record, listing assets, and 1.0.0 build now sitting in App Review, with the bundle-identifier rename (#72) and publisher account ticked off. Also ignores build/ in eslint, matching .gitignore: the App Store archive parked there carries .app copies of the bundles that are not lintable source, and a local archive otherwise breaks npm run lint. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the two follow-ups from the #76 review, plus one piece of local-tooling hygiene.
Regression test for the precedence fix
#76's change to
loadBlockInspectorPrefshipped with no coverage; the review verified empirically that reintroducing the exact bug the new guard prevents (explicit per-originfalsefalling through to a_globaltrue) passed the whole suite. New content-lifecycle block [41] closes that: it stubsWPDBlockInspectoron the harness context and asserts all four precedence outcomes through the real content script. The suite is now 286 assertions; the injected-regression check fails as intended with the new block in place.ROADMAP accuracy
Store states an external contributor cannot see from the repo:
eslint ignore for build/
build/(gitignored since #75) holds the App Store archive and exported installer. The archived.appcontains copies of the shipped bundles, so a local archive breaksnpm run lintwith ~175 errors on files that are not lintable source. Added to the eslint ignores alongsidesafari-build/.No runtime changes;
dist/untouched.🤖 Generated with Claude Code