Highlight: Color Variables are detached from presets when changing styles

[hanneslsm]

Description

When changing the theme styles the color of the highlight doesn't change because it gets detached from the preset and is displayed as a custom color.

Step-by-step reproduction instructions

1. Highlight a text, chose a preset color
2. Change theme styles
3. See that the color preset got overwritten

Screenshots, screen recording, code snippet

Screen.Recording.2023-07-29.at.13.56.37.mp4

Environment info

• WP 6.3-RC2
• ProLooks UI Theme: https://github.com/hanneslsm/ProLooksUI

Please confirm that you have searched existing issues in the repo.

No

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

[stacimc]

I see this on Twenty Twenty Three as well. I chose theme preset colors for the text and background color of a Paragraph block, and then separately applied different (also preset) colors for text & background highlight on a word:

After switching theme styles, the colors for the Paragraph block switch to preset values for the newly selected theme style, but the highlight colors are preserved as custom colors:

[github-actions]

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

[karmatosed]

Thank you for reporting this. I can confirm I also see this in the latest version of the plugin and Twenty Twenty-Four. I agree that the expectation for preset colors for me also is that they change when switching.

To outline what should happen:

• Assign a preset color to a highlight background or text color.
• On changing that color preset it also changes the highlight background and text color.

I do slightly see that the expectation might be argued you are selecting from the presets not setting a variable color at that point, but as highlighting can impact the styling quite a lot, I suspect having it change to presets is going to be more preferable long term.

Let's see about getting this both having other opinions and not with the stale label anymore.

[hanneslsm]

I'm closing this issue in favor of #70025 which has an PR connected already, even though Mikes issue is newer.