Merged
Conversation
This PR adds aria-hidden="true" and role="img" to the SVG files inside the dashicons component, addressing feedback here: #1012 (comment) Upstream PR: WordPress/dashicons#194 CC: @afercia
youknowriad
approved these changes
Jun 6, 2017
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Did you try removing the ="true" from the aria-hidden="true"? I think React is smart enough to add it.
Anyway, LGTM 👍
Contributor
Author
|
Nice, thank you! I did not try and remove the true, but I did try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
aria-hidden="true"androle="img"to the SVG files inside the dashicons component, addressing feedback here: #1012 (comment)Upstream PR: WordPress/dashicons#194
Test instructions:
CC: @afercia