New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try: Move block toolbar below block contents #10462

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tofumatt
Member

tofumatt commented Oct 10, 2018

Currently a WIP.

Fix #3976. This attempts to move the block toolbar below the block contents, to address #3976. That said: right now it doesn't really fulfil that function because it's contextually rendered.

Show/hiding this with CSS rather than contextually rendering it might fix things.

@afercia

This comment has been minimized.

Contributor

afercia commented Nov 4, 2018

Thanks for working on this. It's important to remind that visual order must match DOM order.

Moving the toolbar after the block contents is something the accessibility team asked to explore in #3976 but it also implies that the visual order should be changed. That's the reason why we've proposed a user setting for this, as the visual/DOM position at the bottom might not be desirable for all users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment