try: Move block toolbar below block contents#10462
Closed
Conversation
tofumatt
added
[Focus] Accessibility (a11y)
Contributor
|
Thanks for working on this. It's important to remind that visual order must match DOM order. Moving the toolbar after the block contents is something the accessibility team asked to explore in #3976 but it also implies that the visual order should be changed. That's the reason why we've proposed a user setting for this, as the visual/DOM position at the bottom might not be desirable for all users. |
gziolo
added
[Status] Stale
Member
|
@tofumatt what's the status of this PR? Does it need to be reviewed by designers? I'm marking it as |
Member
|
Let's close this one as it was a technical exploration and it doesn't look like it is going to be implemented this way. @tofumatt thank you for working on it 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a WIP.
Fix #3976. This attempts to move the block toolbar below the block contents, to address #3976. That said: right now it doesn't really fulfil that function because it's contextually rendered.
Show/hiding this with CSS rather than contextually rendering it might fix things.