Skip to content

Fix a few full width issues#1075

Merged
jasmussen merged 4 commits intomasterfrom
fix/full-width-issues
Jun 8, 2017
Merged

Fix a few full width issues#1075
jasmussen merged 4 commits intomasterfrom
fix/full-width-issues

Conversation

@jasmussen
Copy link
Contributor

This PR addresses a few issues in the new full width setup:

  • An edgecase where floated images would be off, when you stickied the left menu
  • The inserter indicator is now better sized
  • Fixed padding issues that created a discrepancy between the post title and blocks in the editor
  • The main column width is reduced, because other issues in the full width branch changed how this was calculated

jasmussen added 4 commits June 8, 2017 11:52
Sticky menu + post settings open meant for a unique bug.
This makes the paddings and margins the same between post title and blocks.
This addresses the fact that recent padding/margin changes has made the column wider again. This changes the main editor variable to make the main column the same width as it used to be.

SCSS HOORAAY!
@jasmussen jasmussen self-assigned this Jun 8, 2017
@jasmussen jasmussen requested review from mtias and youknowriad June 8, 2017 10:10
@jasmussen jasmussen merged commit 321a8e8 into master Jun 8, 2017
@jasmussen jasmussen deleted the fix/full-width-issues branch June 8, 2017 13:50
@jasmussen
Copy link
Contributor Author

Got verbal approval from Matías for a merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant