Improve mobile inserter and post settings#1089
Merged
Conversation
This fixes scroll bleed when post settings is open on mobile. It also fixes the vertical position of it. The downside here is that you lose your place in the editor when you open modal. This is similar behavior to WordPress.com, and it's an improvement on the old editor where you'd have to scroll to the metaboxes below the editor regardless. But it might be worth looking into fixing this with JS down the road.
youknowriad
reviewed
Jun 9, 2017
editor/sidebar/style.scss
Outdated
| .editor-layout.is-sidebar-opened .editor-layout__content { | ||
| margin-right: $sidebar-width; | ||
| margin-left: -200%; | ||
| float: left; |
Contributor
There was a problem hiding this comment.
Mixed spaces/tabs indentation :)
Contributor
|
Works great aside a small gap at the bottom of the inserter |
Contributor
Author
|
The gap at the end is due to some sticky positioning combined with I think this is best addressed separately, as part of #656. |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a number of things:
The only downside to this PR is that if you are on mobile, and are editing a long document, then open post settings, you lose your place (i.e. you are scrolled to the top). This is actually the same behavior that's on WordPress.com, and it's not really a regression from the current editor where you'd have to scroll to the bottom where the metaboxes live regardless.
But depending on how we deal with the inspector on mobile, we might want to separately address this positioning issue using JS. Potentially we could do that as part of fixing #656.