Merged
Conversation
Member
Author
|
No problem. I created #1097 to discuss the server-side initialization further. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/WordPress/gutenberg/pull/870/files#r120894090 and https://github.com/WordPress/gutenberg/pull/870/files#r121213401:
init, at least in our main plugin.lib/directory so that it will be scanned byphpcs(also broken currently, another PR coming up for this).npm run package-plugin- currently it generates broken builds.Placing PHP code inline with its block code in the
blocks/librarydirectory makes these last two steps in particular a good bit more difficult. I think all PHP code should live underlib/and all JavaScript code should live elsewhere (under the already-defined Webpack entry points); given that we have to do path manipulation every time we mix the two, it doesn't seem like a good idea.