Panel header a11y: heading and buttons aria-labels#1101
Merged
Conversation
ellatrix
reviewed
Jun 10, 2017
| <IconButton | ||
| onClick={ toggleSidebar } | ||
| icon="no-alt" | ||
| label={ __( 'Close post settings sidebar' ) } |
Member
There was a problem hiding this comment.
Does "sidebar" make sense in this context? Just wondering. :)
Contributor
Author
There was a problem hiding this comment.
Sorry I forgot to reply... well I thought to give some feedback about the "what" post settings is... the wording can be certainly reviewed and improved, I have no strong opinions about that. We should also consider screen readers are used also by low vision users.
ellatrix
approved these changes
Jun 10, 2017
Contributor
Author
|
@iseulde thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to improve a bit the sidebars (panels) header accessibility:
<strong>element in a<h2>I'm not sure if you prefer to use a CSS class to target and style the
h2.About the "admin settings" button, please refer to the note on the issue.
Fixes #1099