Avoid PHP notices in e2e tests plugins#13094
Merged
youknowriad merged 1 commit intomasterfrom Dec 25, 2018
Merged
Conversation
youknowriad
added
the
[Type] Automated Testing
youknowriad
force-pushed
the
update/e2e-test-plugins
branch
from
f5d2824 to
20af7ee
Compare
Contributor
Author
|
Going to merge as just test tweaks and everyone is out :) 🎅 |
Contributor
|
You're the hero we need even if we don't deserve you. |
youknowriad
added a commit
that referenced
this pull request
Jan 9, 2019
youknowriad
added a commit
that referenced
this pull request
Jan 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #13088
This PR fixes some small issues with the e2e tests plugins generating PHP notices causing the tests to fail if you run them in DEBUG mode.