New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Google Docs table paste #13543

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
4 participants
@iseulde
Copy link
Member

iseulde commented Jan 28, 2019

Description

Fixes #11193. Moves removing invalid phrasing content removal logic to removeInvalidHTML, so it is removed after removing nodes that are invalid according to the schema. Currently tables from Google Docs have the following structure: b > div > table, where div is unknown content. This unknown content should first be removed before we can say that b contains known block content.

How has this been tested?

In Chrome, select a whole table and paste it in Gutenberg.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@iseulde iseulde requested review from samikeijonen and WordPress/gutenberg-core Jan 28, 2019

@gziolo gziolo added this to the 5.0 (Gutenberg) milestone Jan 29, 2019

@noisysocks
Copy link
Member

noisysocks left a comment

I followed the steps to reproduce in #11193 and this PR seems to fix the bug! 👍

Occasionally when I copy a table in Google Docs my clipboard contains only <tr> nodes without a <table> which makes rawHandler not insert a table block. It'd be good if we could detect this and still insert a table block.

@iseulde

This comment has been minimized.

Copy link
Member Author

iseulde commented Feb 1, 2019

@noisysocks Yeah, I'm aware. I'll fix it when I find some time.

@iseulde

This comment has been minimized.

Copy link
Member Author

iseulde commented Feb 1, 2019

Thanks for the review!

@iseulde iseulde merged commit dfc970d into master Feb 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@iseulde iseulde deleted the fix/gdocs-table-paste branch Feb 1, 2019

daniloercoli added a commit that referenced this pull request Feb 1, 2019

Merge branch 'master' of https://github.com/WordPress/gutenberg into …
…rnmobile/372-use-RichText-on-Title-block

* 'master' of https://github.com/WordPress/gutenberg:
  Try alternate list item jump fix. (#12941)
  Mobile bottom sheet component (#13612)
  Remove unintentional right-margin on last odd-item. (#12199)
  Introduce left and right float alignment options to latest posts block (#8814)
  Fix Google Docs table paste (#13543)
  Increase bottom padding on gallery image caption (#13623)
  Fix the editor save keyboard shortcut not working in code editor view (#13159)
  Plugin: Deprecate gutenberg_add_admin_body_class (#13572)
  Rnmobile/upload media failed state (#13615)
  Make clickOnMoreMenuItem not dependent on aria labels (#13166)
  Add: className prop support to server side render. (#13568)
  Fix: Categories Block: hierarchical Dropdown (#13567)
  Docs: Add clarification about git workflow (#13534)
  Plugin: Remove `user_can_richedit` filtering (#13608)
  eslint-plugin: Add rule `no-unused-vars-before-return` (#12828)
  Image settings button (#13597)
  Fixed wording for the color picker saturation (#13479)

# Conflicts:
#	packages/block-library/src/image/edit.native.js
@samikeijonen

This comment has been minimized.

Copy link
Contributor

samikeijonen commented Feb 1, 2019

Thanks for this @iseulde!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment