Move fade animation to the Animate component#17167
Closed
kjellr wants to merge 5 commits into
Closed
Conversation
Contributor
|
Closing this out due to inactivity! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once #17106 is merged in, this PR will handle the final migration of animations from
_animations.scssinto the Animate component. Moving these into the Animate component will allow the animations to be much more self-contained, and prevent us from separately declaring the keyframe declarations in each environment where they need to be used.Some of these are a bit beyond my expertise, so if anyone else wants to pitch in, please feel free to push directly to this PR (and thank you in advance! 🙌)!
Tasks
fade-inanimation to the Animate componentblock-moversto use the new animationinserter-with-shortcutsto use the new animationinserterhelp panel to use the new animationmodalto use the new animationfullscreen-modeto use the new animation_animations.scssfile, and stop it from being included in all other SCSS files.packages/edit-widgets/src/style.scss,playground/src/style.scss, andpackages/edit-post/src/style.scss(If it ends up making sense to break these out into separate PRs, we can do that)