Framework: Remove unused Travis install dependencies#18924
Conversation
Turns out I was searching the built copy of WordPress, not It's a bit awkward that we satisfy these dependencies this way (vs. installing based on the copied I've restored the removed line, but also think it would be wise to include additional comments for future maintainers who find themselves in a similar state of confusion as myself. I've expanded on the existing comment in f609dc6. |
gziolo
left a comment
There was a problem hiding this comment.
If this is meant to include the code comment after all, it's good to go :)
|
Yep, only intending to include the clarifying comment after discovering the purpose by which it's needed. Thanks! |
Previously: #17004
This pull request seeks to remove the installation step of two seemingly unused dependencies from the Travis configuration
installstage. There are no other references to eitherdotenvorwait-onanywhere in Gutenberg orwordpress-develop, so as best I can tell, they should not be necessary. My assumption is that they were considered in early iterations of #17004 as an alternative to thesleep 10command which follows a few lines after the removed line.Testing Instructions:
Travis build should pass.