[Mobile] - Buttons block - Support content justification#26166
Merged
ZebulanStanphill merged 1 commit intoOct 17, 2020
Merged
Conversation
geriux
added
[Status] In Progress
6 tasks
|
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
ZebulanStanphill
force-pushed
the
update/buttons-block-align-options
branch
from
67463b4 to
225ff95
Compare
Member
ZebulanStanphill
left a comment
ZebulanStanphill
left a comment
There was a problem hiding this comment.
Test failures appear to be unrelated and caused by test issues that were present in master (but now fixed, I think). I've rebased #23168, so rebasing this branch should get tests to pass.
I have no way to actually test the code, but just looking at it, I can't see any mistakes. 👍
…tificationDropdown
geriux
force-pushed
the
rnmobile/buttons-block-align-options
branch
from
cf67f4a to
335d430
Compare
Member
Author
Thanks! Just updated the branch |
ZebulanStanphill
pushed a commit
that referenced
this pull request
Oct 21, 2020
…tificationDropdown (#26166)
ZebulanStanphill
pushed a commit
that referenced
this pull request
Oct 28, 2020
…tificationDropdown (#26166)
ZebulanStanphill
added a commit
that referenced
this pull request
Oct 28, 2020
* Buttons block: overhaul alignment/justification controls. * Make icon names consistent with CSS terminology. * Move onClick function inline. * Mobile - Buttons block - Support content justification and ContentJustificationDropdown (#26166) * Fix control title inconsistency. Co-authored-by: Gerardo Pacheco <gerardo.pacheco@automattic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a continuation of #23168 adding support of content justification and the
ContentJustificationDropdownfor mobile.How has this been tested?
Screenshots
Types of changes
New feature
Checklist: