Properly handle 404 errors while publishing Android artifacts#32860
Merged
Conversation
oguzkocer
added
the
Mobile App - i.e. Android or iOS
AliSoftware
approved these changes
Jun 21, 2021
AliSoftware
left a comment
AliSoftware
left a comment
There was a problem hiding this comment.
I've tested these changes by calling ./gradlew checkIfVersionIsAlreadyPublished -P publishReactNativeAztecVersion=3573-82ae7effff33b6de8078f187206300e2da874e2c with that code earlier today, and saw the expected 404 error being caught, so LGTM.
mchowning
approved these changes
Jun 21, 2021
Contributor
mchowning
left a comment
mchowning
left a comment
There was a problem hiding this comment.
Looks good! Thanks @oguzkocer ! 🙇
2 tasks
dcalhoun
pushed a commit
that referenced
this pull request
Jun 22, 2021
5 tasks
dcalhoun
added a commit
that referenced
this pull request
Jun 23, 2021
* Release script: Update react-native-editor version to 1.55.0 * Release script: Update with changes from 'npm run core preios' * Release script: Update react-native-editor version to 1.55.1 * Release script: Update with changes from 'npm run core preios' * Fix: RNMobile borderRadius value setting (#32717) * [RNMobile] Improve unsupported block message for reusable block (#32618) * Improve unsupported block message for reusable block The unsupported block message has been updated and the convert to regular blocks button has been also included. * Update unsupported block message of reusable block * Update react-native-editor changelog * Release script: Update react-native-editor version to 1.55.2 * Release script: Update with changes from 'npm run core preios' * Fix incorrect block insertion point after blurring post title (#32831) Selecting the title selection status within the same `useSelect` for reusable blocks caused the title selection status to become stale, due to the dependency array for the `useSelect` hook. The staleness caused the block insertion point to show up in the incorrect location after blurring the title text input. * Update changelog * Properly handle 404 errors while publishing Android artifacts (#32860) Co-authored-by: Antonis Lilis <antonis.lilis@automattic.com> Co-authored-by: Carlos Garcia <fluiddot@gmail.com> Co-authored-by: Enej Bajgoric <enej.bajgoric@automattic.com> Co-authored-by: Oguz Kocer <oguzkocer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have made a change to the ACL settings of our S3 bucket where we publish Android artifacts to return 404 error instead of 403 for files that don't exist. This resulted in a regression in our
checkIfVersionIsAlreadyPublishedGradle task inreact-native-aztec&react-native-bridgeprojects.Please note that this check will be removed and these build files will be refactored in a few days.
How has this been tested?
I've tried manually publishing a
react-native-aztecversion that exists in S3 and got the following error as expected:I don't think there is any testing necessary from the reviewer. S3 publishing requires credentials and we only have them in our CIs. I think it's best to merge this in and update
gutenberg-mobileto verify that the issue is resolved.Types of changes
Android build file changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).