updateBlockListSettings: convert state to Map, do all updates in one action#46392
Merged
updateBlockListSettings: convert state to Map, do all updates in one action#46392
Conversation
|
Size Change: +33 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
Member
|
Hi, @jsnajdr Was there a reason we never implemented this change? I'm happy to take over if you still think there are some performance gains here. |
Member
Author
@Mamaduka I guess the performance tests didn't show the speed-up that I was hoping for. This PR want meant a follow-up to $46146 and #46204. These two PRs did similar object-to-map refactoring for other parts of state, and they had impact on the numbers. I think it's still a good idea to rebase this and try it again. If nothing else, it will be a nice refactoring that makes the codebase more consistent: use the same data structure for the same type of data. Not a random mix of objects and maps. |
Member
|
Returning to this PR. I think it would be a nice addition to the recent improvements we're making for the Block Editor store. @jsnajdr, when you have time, do you mind rebasing and resolving merge conflicts? |
Member
Author
|
@Mamaduka Yes, I agree it's a good idea to convert the Another part that would be a very nice |
jsnajdr
force-pushed
the
optimize/block-list-settings-batch
branch
from
80fde67 to
851f1cd
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jsnajdr
force-pushed
the
optimize/block-list-settings-batch
branch
from
851f1cd to
0f2ca41
Compare
Mamaduka
reviewed
Apr 7, 2026
Comment on lines
+2481
to
+2485
| .filter( | ||
| ( [ , listSettings ] ) => | ||
| listSettings?.templateLock === 'contentOnly' | ||
| ) | ||
| .map( ( [ clientId ] ) => clientId ); |
Member
There was a problem hiding this comment.
Do you think it's worth replacing similar filter/maps with something like - https://github.com/vercel-labs/agent-skills/blob/main/skills/react-best-practices/rules/js-flatmap-filter.md?
Member
Author
There was a problem hiding this comment.
Yes, I pushed a commit that implements this change. I've been thinking about flatMap, too, when seeing the updated code. But we don't use flatMap much, that's why I stayed with the classic filter/map initially.
Member
There was a problem hiding this comment.
We start using it more. It's a nice pattern.
|
Flaky tests detected in 15669a0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24121521086
|
Member
|
@jsnajdr, should we also update usage in |
jsnajdr
force-pushed
the
optimize/block-list-settings-batch
branch
from
9dde1ba to
15669a0
Compare
Member
Author
This is already done, isn't it? The original version of this PR from 2022 contained this change, but then it got done independently as part of #61329. We dispatch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the
state.blockListSettingsstate to aMap, hoping to make it faster. And when there are multiple pending updates for block list settings, do them inside oneupdateBlockListSettingsaction. That should be much faster thatregistry.batch(), because we're not creating a new state tree for the entire store for each update.