Fix instanceof failed on iframe editor#54643
Closed
bangank36 wants to merge 1 commit intoWordPress:trunkfrom
Closed
Fix instanceof failed on iframe editor#54643bangank36 wants to merge 1 commit intoWordPress:trunkfrom
bangank36 wants to merge 1 commit intoWordPress:trunkfrom
Conversation
Contributor
Author
|
Closed in favor of #54669 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Address #54378
Why?
Since blocks are rendered inside iframe, which has its own environment with its own globals, the check
gutenberg/packages/components/src/date-time/time/index.tsx
Line 130 in 6999011
will be against the parent window not the iframe, thus it returns false and stop the Time inputs to fire properly
How?
TBA
Testing Instructions
For quick testing purpose, the Time component is included in ButtonEdit
Testing Instructions for Keyboard
Screenshots or screencast
Kapture.2023-09-20.at.11.05.14.mp4
cc: @ciampo @Honkitonkie