Conversation
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @galbaras. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
commented
Apr 1, 2024
|
Size Change: +23 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Apr 1, 2024
ellatrix
commented
Apr 1, 2024
| exports[`Blocks raw handling should correctly handle quotes with mixed content 1`] = ` | ||
| "<!-- wp:quote --> | ||
| <blockquote class="wp-block-quote"><!-- wp:heading {"level":1} --> | ||
| <blockquote class="wp-block-quote"><!-- wp:heading {"level":1,"className":"wp-block-heading"} --> |
Member
Author
There was a problem hiding this comment.
Not sure why you'd ever have content to convert that has such a class, but this is the test 🤷♀️
const filtered = serialize(
pasteHandler( {
HTML: '<blockquote><h1 class="wp-block-heading">chicken</h1><p>ribs</p></blockquote>',
mode: 'AUTO',
} )
); 
|
Thank you for adding class handling, @ellatrix. It would be good to add handling for id, even if only for the sake of completion, but possibly for actual value. It would also be good to confirm that classes and IDs aren't stripped from (inline) elements within block-level ones, e.g. span or a tags within paragraphs, list items, blockquotes, etc. BTW, I've linked my GitHub profile to wp.org. |
Member
Author
|
@galbaras In that case, could you create a new issue? |
|
Testing shows that inline elements are handled OK for |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Unlinked contributors: galbaras. Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds a filter to add custom class names to block attributes when converting to blocks (from classic, not paste).
To do: if conceptually approved, add small integration test.Why?
Fixes #42172.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast